[drraw-users] Two bugs in 2.2a3
Christophe Kalt
kalt at taranis.org
Mon Apr 23 20:37:37 EDT 2007
Hi,
On Apr 23, Garrett Wollman wrote:
| A colleague was trying to get a graph that showed just the last eight
| hours on a particular switch port. He started with a filtered
| dashboard, drilled down to the port in question, selected just the
| "Past 28 hours" view, and changed the starting time to "end - 8
| hours", then clicked "view". He found (and I confirmed) that this
| loses the currently-selected data source, and presents him with the
| source-selection box for that template. It also loses the filter
| specification, so he gets shown all of the possible data sources (a
| few thousand in our network) rather than just the ones on the switch
| he is interested in.
Yes, i'm overdue for a new release.
http://web.taranis.org/pipermail/drraw-users/2007q1/000135.html
has the fix.
| When looking at the generated HTML, I also noticed that the <style>
| element has nested HTML comments, which are not valid. The standard
| way of doing this is:
|
| <style>//<![CDATA[
| ...style sheet data goes here...
| //]]></style>
|
| (at least in XHTML). However, it's almost always better to use an
| external style sheet; this will allow the browser to cache the style
| sheet, providing for quicker loads and reloads.
i have to admit i am out of touch for this.
drraw isn't supposed to generate XHTML, i forget why, but it
caused me problems a while back. (Probably something wrong
with the CGI module.)
use CGI qw(:standard :html3 *table *ul -no_xhtml -nosticky);
As far as the above comment, i'll need to read up on this and
fix it then. With regards to separating the style sheet, it
poses its own set of "problems", either:
- a second instance of drraw which is relatively costly given
the fact it's in Perl
or
- served directly by the web server, making drraw less
self-contained
Neither's very appealing to me, and the style sheet is small
enough that i don't think it's a big deal either.
More information about the drraw-users
mailing list