From kalt at taranis.org  Mon Feb  1 18:52:05 2010
From: kalt at taranis.org (Christophe Kalt)
Date: Mon, 1 Feb 2010 20:52:05 -0500
Subject: [drraw-users] drraw bug report
In-Reply-To: <57403EFC11A7D24F99E37576E21C5E3301385F57@elab4vm1.elabnet.com>
References: <57403EFC11A7D24F99E37576E21C5E3301385F57@elab4vm1.elabnet.com>
Message-ID: <7c3a19501002011752t6aeb6c02l43f390e4348ecfe@mail.gmail.com>

In case anyone's got some time to look at this..  (i don't.)

---------- Forwarded message ----------
From: Michael Markstaller <mm at elabnet.de>
Date: Sun, Jan 31, 2010 at 19:40
Subject: drraw bug report
To: drraw-bugs at taranis.org


drraw version: 2.2b2, Perl 5.010000, CGI 3.29, RRD 1.3001 on linux with
lighttpd/1.4.19

When special characters (?C, german umlauts etc) in graphs are saved first
off everything is fine but when they get loaded for edit it's messed up in
the form-display and then saved wrong.
Attached two screenshots, one is from a newly created graph and the second
when you click first on "Edit"..
Browser and enconding (default ISO8859-1) seems all fine.

I wasn't able to find a simple solution myself, I just got that far it's
something the params are saved by CGI with utf-8 representation but
obviously not decoded right when sent to the edit form back again.. when
changing the whole thing to UTF8 things didn't get better either.


Already reported this once here:
http://box557.bluehost.com/pipermail/drraw-users_lists.taranis.org/2009q3/000385.html


Thanks, Michael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://box557.bluehost.com/pipermail/drraw-users_lists.taranis.org/attachments/20100201/e4e8e737/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hc_006.jpg
Type: image/jpeg
Size: 3878 bytes
Desc: not available
URL: <http://box557.bluehost.com/pipermail/drraw-users_lists.taranis.org/attachments/20100201/e4e8e737/attachment.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hc_007.jpg
Type: image/jpeg
Size: 10452 bytes
Desc: not available
URL: <http://box557.bluehost.com/pipermail/drraw-users_lists.taranis.org/attachments/20100201/e4e8e737/attachment-0001.jpg>

From brevius at tlen.pl  Fri Mar 19 05:39:35 2010
From: brevius at tlen.pl (brevius at tlen.pl)
Date: Fri, 19 Mar 2010 12:39:35 +0100
Subject: [drraw-users] =?utf-8?q?Importing_descriptions_from_a_file?=
Message-ID: <6f52bc11.6792097b.4ba36277.c245f@tlen.pl

Hi,

My RRD files have "numeric" naming scheme (10.50.60.1-somename-somenumber-someothernumber.rrd). Wehn I'm creating a template, the raw values are put on the graph as a legend or graph description.
I'm not perl expert but I think it is possible to import descriptions from external file (for example 3340 - VLAN_admin) and put on the graph the description instead raw number. Could you give me some hint where to look at drraw code to find possible "place" to make some modifications?

Tomek


From eric.buckhalt at oit.gatech.edu  Tue Mar 23 07:22:43 2010
From: eric.buckhalt at oit.gatech.edu (eric.buckhalt at oit.gatech.edu)
Date: Tue, 23 Mar 2010 09:22:43 -0400 (EDT)
Subject: [drraw-users] DrRaw generating paths with double "/"
In-Reply-To: <1980243485.9021269350066686.JavaMail.root@mail9.gatech.edu>
Message-ID: <57398329.9511269350563274.JavaMail.root@mail9.gatech.edu>

I think I may have discovered a bug.  I'm working on resolving it, but if anybody knows right where to go I'd appreciate the help.

We have a pretty large deployment and utilize the RRDCACHED features of rrodtool 1.4.  When drraw.cgi is rrdcached aware things are not getting flushed from the rrd queue as expected.  

The doubles slashes work fine directly accessing the filesystem, but when going through rrdcache it doesn't work right.  Because rrdcache has the file in its queue with a single slash, it fails to flush it when called with the double slash. This causes our graphs to be behind.  If rrdcache could find the entry it would flush all the data for that file to disk before rendering the graph and provide a current graph.

It seems like drraw generates double slashes between the datadir and the rrd file.  I've also noticed a proliferation of double slashes (%2F%2F) throughout the graph and template definitions.  Does anybody know what portion(s) of code causes this?

example:
datadir in drraw.conf: 
%datadirs = ('/srv/stats_receiver/rrd_files'  => 'Prototype Repository',
            );
generated file name: /srv/stats_receiver/rrd_files//server.gatech.edu/nac/leasesused-vlan1296.rrd

-- 
Eric Buckhalt		
eric.buckhalt at oit.gatech.edu
404 385 0545
Georgia Tech OIT/A&I


From wernli at in2p3.fr  Wed Mar 24 08:40:12 2010
From: wernli at in2p3.fr (Fabien Wernli)
Date: Wed, 24 Mar 2010 15:40:12 +0100
Subject: [drraw-users] DrRaw generating paths with double "/"
In-Reply-To: <57398329.9511269350563274.JavaMail.root@mail9.gatech.edu>
References: <1980243485.9021269350066686.JavaMail.root@mail9.gatech.edu>
	<57398329.9511269350563274.JavaMail.root@mail9.gatech.edu>
Message-ID: <20100324144012.GG4040@ccswiss.in2p3.fr>

On Tue, Mar 23, 2010 at 09:22:43AM -0400, eric.buckhalt at oit.gatech.edu wrote:
> It seems like drraw generates double slashes between the datadir and the rrd file.  I've also noticed a proliferation of double slashes (%2F%2F) throughout the graph and template definitions.  Does anybody know what portion(s) of code causes this?

I'd strongly suggest using File::Spec while you're at it.



From kalt at taranis.org  Wed Mar 24 09:15:26 2010
From: kalt at taranis.org (Christophe Kalt)
Date: Wed, 24 Mar 2010 11:15:26 -0400
Subject: [drraw-users] DrRaw generating paths with double "/"
In-Reply-To: <57398329.9511269350563274.JavaMail.root@mail9.gatech.edu>
References: <1980243485.9021269350066686.JavaMail.root@mail9.gatech.edu> 
	<57398329.9511269350563274.JavaMail.root@mail9.gatech.edu>
Message-ID: <7c3a19501003240815s2bd2f79dy660351663bf30b50@mail.gmail.com>

The double slashes are used as separators in the templating code, nothing
wrong about them.  It should be a simple matter to strip them before calls
to rrdcache if they're causing problems with it.

On Tue, Mar 23, 2010 at 09:22, <eric.buckhalt at oit.gatech.edu> wrote:

> I think I may have discovered a bug.  I'm working on resolving it, but if
> anybody knows right where to go I'd appreciate the help.
>
> We have a pretty large deployment and utilize the RRDCACHED features of
> rrodtool 1.4.  When drraw.cgi is rrdcached aware things are not getting
> flushed from the rrd queue as expected.
>
> The doubles slashes work fine directly accessing the filesystem, but when
> going through rrdcache it doesn't work right.  Because rrdcache has the file
> in its queue with a single slash, it fails to flush it when called with the
> double slash. This causes our graphs to be behind.  If rrdcache could find
> the entry it would flush all the data for that file to disk before rendering
> the graph and provide a current graph.
>
> It seems like drraw generates double slashes between the datadir and the
> rrd file.  I've also noticed a proliferation of double slashes (%2F%2F)
> throughout the graph and template definitions.  Does anybody know what
> portion(s) of code causes this?
>
> example:
> datadir in drraw.conf:
> %datadirs = ('/srv/stats_receiver/rrd_files'  => 'Prototype Repository',
>            );
> generated file name: /srv/stats_receiver/rrd_files//
> server.gatech.edu/nac/leasesused-vlan1296.rrd
>
> --
> Eric Buckhalt
> eric.buckhalt at oit.gatech.edu
> 404 385 0545
> Georgia Tech OIT/A&I
>
> _______________________________________________
> drraw-users mailing list
> drraw-users at box557.bluehost.com
> http://box557.bluehost.com/mailman/listinfo/drraw-users_lists.taranis.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://box557.bluehost.com/pipermail/drraw-users_lists.taranis.org/attachments/20100324/74d4079a/attachment.html>

From eric.buckhalt at oit.gatech.edu  Wed Mar 31 10:38:44 2010
From: eric.buckhalt at oit.gatech.edu (eric.buckhalt at oit.gatech.edu)
Date: Wed, 31 Mar 2010 12:38:44 -0400 (EDT)
Subject: [drraw-users] DrRaw generating paths with double "/"
In-Reply-To: <642693324.56211270053352921.JavaMail.root@mail9.gatech.edu>
Message-ID: <486277961.56311270053524277.JavaMail.root@mail9.gatech.edu>

We ended up removing the double slashes when building @DEF before calling RRDs::graph. It may not be the broadest solution, as I think we don't flush correctly when querying RRD info on the graph edit screen. 

For those that may be interested here is our diff. 

diff drraw.cgi drraw.cgi.bak 
2506,2513d2505 
< # MODIFICATION #1 
< sub Clean_Path 
< { 
< my ($file) = (@_); 
< $file =~ s://:/:g; 
< return $file; 
< } 
< 
3549,3552c3543 
< # ORIGINAL 
< # $ds . $count .'='. $file, # ORIGINAL 
< # MODIFICATION 
< $ds . $count .'='. Clean_Path($file), 
--- 
> $ds . $count .'='. $file, 
3632,3635c3623 
< # ORIGINAL 
< # push @DEF, join(':', 'DEF', $ds .'='. $file, 
< # MODIFICATION 
< push @DEF, join(':', 'DEF', $ds .'='. Clean_Path($file), 
--- 
> push @DEF, join(':', 'DEF', $ds .'='. $fi 




----- Original Message ----- 
From: "Christophe Kalt" <kalt at taranis.org> 
To: "eric buckhalt" <eric.buckhalt at oit.gatech.edu> 
Cc: drraw-users at taranis.org 
Sent: Wednesday, March 24, 2010 11:15:26 AM GMT -05:00 US/Canada Eastern 
Subject: Re: [drraw-users] DrRaw generating paths with double "/" 

The double slashes are used as separators in the templating code, nothing wrong about them. It should be a simple matter to strip them before calls to rrdcache if they're causing problems with it. 


On Tue, Mar 23, 2010 at 09:22, < eric.buckhalt at oit.gatech.edu > wrote: 


I think I may have discovered a bug. I'm working on resolving it, but if anybody knows right where to go I'd appreciate the help. 

We have a pretty large deployment and utilize the RRDCACHED features of rrodtool 1.4. When drraw.cgi is rrdcached aware things are not getting flushed from the rrd queue as expected. 

The doubles slashes work fine directly accessing the filesystem, but when going through rrdcache it doesn't work right. Because rrdcache has the file in its queue with a single slash, it fails to flush it when called with the double slash. This causes our graphs to be behind. If rrdcache could find the entry it would flush all the data for that file to disk before rendering the graph and provide a current graph. 

It seems like drraw generates double slashes between the datadir and the rrd file. I've also noticed a proliferation of double slashes (%2F%2F) throughout the graph and template definitions. Does anybody know what portion(s) of code causes this? 

example: 
datadir in drraw.conf: 
%datadirs = ('/srv/stats_receiver/rrd_files' => 'Prototype Repository', 
); 
generated file name: /srv/stats_receiver/rrd_files// server.gatech.edu/nac/leasesused-vlan1296.rrd 

-- 
Eric Buckhalt 
eric.buckhalt at oit.gatech.edu 
404 385 0545 
Georgia Tech OIT/A&I 

_______________________________________________ 
drraw-users mailing list 
drraw-users at box557.bluehost.com 
http://box557.bluehost.com/mailman/listinfo/drraw-users_lists.taranis.org 



-- 
Eric Buckhalt 
eric.buckhalt at oit.gatech.edu 
404 385 0545 
Georgia Tech OIT/A&I 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://box557.bluehost.com/pipermail/drraw-users_lists.taranis.org/attachments/20100331/b5ccb611/attachment.html>